Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new cuml.accel module #6347

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Add new cuml.accel module #6347

merged 1 commit into from
Feb 21, 2025

Conversation

jcrist
Copy link
Member

@jcrist jcrist commented Feb 20, 2025

This is just an alias shim around the old cuml.experimental.accel module, to help avoid merge conflicts or usage of the previous experimental module. In the future we should move the code out of experimental and over to accel instead.

@jcrist
Add new cuml.accel module
7bd6520 
This is just an alias shim around the old `cuml.experimental.accel`
module, to help avoid merge conflicts or usage of the previous
experimental module. In the future we should move the code out of
experimental and over to `accel` instead.
@jcrist jcrist requested review from a team as code owners February 20, 2025 20:25
@github-actions github-actions bot added Cython / Python Cython or Python issue ci labels Feb 20, 2025
@jcrist jcrist added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change cuml-cpu labels Feb 20, 2025
jameslamb
jameslamb approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just giving you the ci-codeowners you need to merge this, as the ci/ changes match the other Python changes.

Will defer to other cuML reviewers on the substance of those namespacing changes.

dantegd
dantegd approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change lgtm pending CI

@dantegd dantegd mentioned this pull request Feb 21, 2025
Draft
21 tasks
@dantegd
Copy link
Member

dantegd commented Feb 21, 2025

/merge

@rapids-bot rapids-bot bot merged commit 272c686 into rapidsai:branch-25.04 Feb 21, 2025
73 of 74 checks passed
dantegd added a commit to dantegd/cuml that referenced this pull request Feb 21, 2025
@dantegd
Backport PR rapidsai#6347
cd9286a
@jcrist jcrist deleted the cuml-accel branch February 21, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

@jameslamb jameslamb jameslamb approved these changes

@viclafargue viclafargue Awaiting requested review from viclafargue viclafargue is a code owner automatically assigned from rapidsai/cuml-python-codeowners

@wphicks wphicks Awaiting requested review from wphicks wphicks is a code owner automatically assigned from rapidsai/cuml-python-codeowners

Assignees
No one assigned
Labels
ci cuml-cpu Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcrist @dantegd @jameslamb